Skip to content

Fix conversion of ctypes pointers passed to C extension#154

Merged
Araneidae merged 3 commits into
masterfrom
fix-153
Mar 12, 2024
Merged

Fix conversion of ctypes pointers passed to C extension#154
Araneidae merged 3 commits into
masterfrom
fix-153

Conversation

@Araneidae

@Araneidae Araneidae commented Mar 12, 2024

Copy link
Copy Markdown
Collaborator

As reported in issue #153 there appears to be a problem in converting a Python integer generated by ctypes.address() back to a void* pointer when naively using PyArg_ParseTuple.

@Araneidae
Fix conversion of ctypes pointers passed to C extension
df92d94 
As reported in issue #153 there appears to be a problem in converting a
Python integer generated by ctypes.address() back to a void* pointer when
naively using PyArg_ParseTuple.  Don't fully understand why this issue
arises, but the fix is straightforward.

Fixes issue #153
@Araneidae
Wrap comment going over 80 column limit
57790d4
@codecov

codecov Bot commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (f2330b6) to head (d55483d).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          14       14           
  Lines        1019     1019           
=======================================
  Hits          894      894           
  Misses        125      125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Mar 12, 2024

Copy link
Copy Markdown

Unit Test Results

     15 files  ±0       15 suites  ±0   27m 43s ⏱️ -19s
   278 tests ±0     262 ✔️ ±0    16 💤 ±0  0 ❌ ±0 
4 170 runs  ±0  3 575 ✔️ ±0  595 💤 ±0  0 ❌ ±0 

Results for commit 57790d4. ± Comparison against base commit f2330b6.

AlexanderWells-diamond
AlexanderWells-diamond approved these changes Mar 12, 2024
View reviewed changes

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs an entry in CHANGELOG.rst, but otherwise it looks fine to me.

@Araneidae Araneidae merged commit d55483d into master Mar 12, 2024
@Araneidae Araneidae deleted the fix-153 branch March 12, 2024 11:31
@Araneidae Araneidae mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderWells-diamond AlexanderWells-diamond AlexanderWells-diamond approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Araneidae @AlexanderWells-diamond